Share docs between compound component of the same parent #3434
+184
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Dec 4, 2024
Inbal-Tish
reviewed
Dec 4, 2024
|
@ethanshar I'm not sure I understand this PR... How will the TabController docs will look like if we want to add docs to both TabBar (exists) and TabPage components? |
…for parent component docs
I discussed with Yulia, she also preferred to remove 🙄 so I removed |
Then why you did remove the docs for the TabBar after moving them to the TabController? Now there is a duplication... |
Inbal-Tish
reviewed
Dec 4, 2024
remove comment
Inbal-Tish
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to share docs between compound components of the same parent I copy the docs entry from the parent to children
for example components like (TabController and its children TabController.TabBar, TabController.TabPage, etc...)
Changelog
Share docs between compound components
Additional info